android - Adding Views dynamically in Linear Layout in Fragment -


i trying add textview nested linearlayout in fragmentin oncreateview, don't know if correct approach or not, new android! in advance

@override public view oncreateview(layoutinflater inflater, viewgroup container, bundle savedinstancestate) {     viewgroup rootview = (viewgroup) inflater.inflate(r.layout.fragment_screen_slide_page, container, false);     list<lifeberrysxmlparser.item> items = (arraylist<lifeberrysxmlparser.item>) getarguments().getserializable("list");     textview mainheading = (textview) rootview.findviewbyid(r.id.mainheading);     imageview mainimage = (imageview) rootview.findviewbyid(r.id.articlemainimage);     linearlayout articlelayout = (linearlayout) rootview.findviewbyid(r.id.articlelayout);     textview tev = new textview(getactivity());     tev.settext("hello..............");     articlelayout.addview(tev);     lifeberrysxmlparser.item item = items.get(getarguments().getint("position"));     string articlemainheading = item.mainheading;     string articlemainimage = item.mainimage;     mainheading.settext(articlemainheading);     if (!articlemainimage.isempty()) {         picasso.with(getcontext()).load(articlemainimage).into(mainimage);     }     return rootview; } 

can please me doing wrong?

here xml fragment

<?xml version="1.0" encoding="utf-8"?>  <linearlayout xmlns:android="http://schemas.android.com/apk/res/android"         android:orientation="vertical" android:layout_width="match_parent"         android:layout_height="match_parent"         android:fillviewport="true"         android:id="@+id/content"         android:padding="1dp"         android:layout_weight="1"         android:background="#000000"         android:layout_gravity="center">          <linearlayout             android:layout_width="match_parent"             android:layout_height="match_parent"             android:orientation="vertical"             android:background="#ffffff"             android:scrollindicators="right">             <relativelayout                 android:layout_width="wrap_content"                 android:layout_height="wrap_content">                 <imageview                     android:layout_width="match_parent"                     android:layout_height="wrap_content"                     android:id="@+id/articlemainimage"                     android:maxheight="300dp"/>                 <textview                     style="?android:textappearancemedium"                     android:layout_width="match_parent"                     android:layout_height="?android:attr/listpreferreditemheightlarge"                     android:layout_weight="1"                     android:linespacingmultiplier="1.2"                     android:id="@+id/mainheading"                     android:textcolor="#ff6435"                     android:clickable="false"                     android:layout_gravity="center"                     android:layout_centerinparent="true"/>             </relativelayout>             <linearlayout                 android:layout_width="match_parent"                 android:layout_height="wrap_content"                 android:id="@+id/articlelayout"                 android:orientation="horizontal">                 <textview                     android:layout_width="match_parent"                     android:layout_height="wrap_content"                     android:text="read more"                     android:textsize="15dp"                     android:textstyle="bold"                     android:layout_gravity="center"                     android:clickable="true"                     android:focusable="false"                     android:gravity="center"                     android:onclick="readmore"                     android:padding="1dp"                     android:textcolor="@android:color/holo_green_light" />             </linearlayout>         </linearlayout> </linearlayout> 

you have mistake in article layout. article layout has horizontal orientation, , it's child textview has match_parent width, when add new child, it'll outside screen. change orientation vertical:

<linearlayout             android:layout_width="match_parent"             android:layout_height="wrap_content"             android:id="@+id/articlelayout"             android:orientation="vertical">      <---- change line             <textview                 android:layout_width="match_parent"                 android:layout_height="wrap_content"                 android:text="read more"                 android:textsize="15dp"                 android:textstyle="bold"                 android:layout_gravity="center"                 android:clickable="true"                 android:focusable="false"                 android:gravity="center"                 android:onclick="readmore"                 android:padding="1dp"                 android:textcolor="@android:color/holo_green_light" />         </linearlayout> 

Comments